Skip to content

Ship 0039/261 - add --scheduler-name flag #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 10, 2025
Merged

Ship 0039/261 - add --scheduler-name flag #311

merged 3 commits into from
May 10, 2025

Conversation

rxinui
Copy link
Contributor

@rxinui rxinui commented Apr 24, 2025 •
edited by SaschaSchwarze0
Loading

Changes

Fixes #261

Add CLI flag --scheduler-name to set .spec.schedulerName to a Build or BuildRun

❗ IMPORTANT: depends on my other PR 309 as v1beta1 is required (and inherently to PR 304)

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Add flag --scheduler-name to set the `.spec.schedulerName` for `build` and `buildrun` on create and run

@openshift-ci openshift-ci bot requested review from adambkaplan and qu1queee April 24, 2025 21:08
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 24, 2025
@rxinui
Copy link
Contributor Author

rxinui commented Apr 24, 2025

/status in-review

@rxinui

This comment was marked as resolved.

Sign in to view
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 24, 2025

@rxinui: The label(s) kind/enhancement cannot be applied, because the repository doesn't have them.

In response to this:

/kind enhancement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rxinui rxinui mentioned this pull request Apr 29, 2025
Merged
4 tasks
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2025
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 30, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2025
@rxinui
Copy link
Contributor Author

rxinui commented Apr 30, 2025

@adambkaplan Now that #260 is merged, this is now rebased on main.

adambkaplan
adambkaplan requested changes Apr 30, 2025
View reviewed changes
Copy link
Member

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Only notable issues seem related to rebasing. Otherwise the code looks good!

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2025
@rxinui rxinui force-pushed the ship-0039/261 branch 2 times, most recently from 7c6ec11 to 2437c64 Compare April 30, 2025 21:41
@rxinui
Copy link
Contributor Author

rxinui commented Apr 30, 2025

@adambkaplan all good now.

On a side note, I'll move back to neovim (or zed).

@rxinui rxinui requested a review from adambkaplan April 30, 2025 21:43
@rxinui
Copy link
Contributor Author

rxinui commented Apr 30, 2025 •
edited
Loading

e2e tests are not ending. None of them are related to my PRs - mine are OK. That is weird. Have you encountered that before?

SaschaSchwarze0
SaschaSchwarze0 requested changes May 4, 2025
View reviewed changes
@rxinui
new: add --scheduler-name to build and buildrun
00729c9 
- test: add go test and bats tests
- ref: harmonise tab/spaces in bats tests

Signed-off-by: rxinui <[email protected]>
@rxinui rxinui requested a review from SaschaSchwarze0 May 4, 2025 13:34
@rxinui
Copy link
Contributor Author

rxinui commented May 4, 2025

@SaschaSchwarze0 i have applied your suggestions. Tests are still OK on my changes yet the bats test on --follow-logs seem to be faulty.

@rxinui
Copy link
Contributor Author

rxinui commented May 9, 2025

@SaschaSchwarze0 i gave another try to Sanitize method. It seems to solve the problem although one test is now faulty.

This is due to the suggestion you made which is

run kubectl get buildruns.shipwright.io -l build.shipwright.io/name=${build_name} -ojsonpath='{.spec.schedulerName}'

There is not output with this get command. I haven't debugged locally yet but perhaps I would assume you did not take into consideration the jsonpath. I think it might required to be -ojsonpath='{.items[*].spec.schedulerName}'

SaschaSchwarze0
SaschaSchwarze0 approved these changes May 10, 2025
View reviewed changes
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2025
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.16.0 milestone May 10, 2025
@SaschaSchwarze0 SaschaSchwarze0 added the kind/feature Categorizes issue or PR as related to a new feature. label May 10, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 7860560 into shipwright-io:main May 10, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaschaSchwarze0 SaschaSchwarze0 SaschaSchwarze0 approved these changes

@qu1queee qu1queee Awaiting requested review from qu1queee

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

Assignees

@SaschaSchwarze0 SaschaSchwarze0

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Shipwright Overview
Status: Done
Milestone
release-v0.16.0
Development

Successfully merging this pull request may close these issues.

SHIP-0039: Command line option to set custom scheduler on Build/BuildRun
4 participants
@rxinui @adambkaplan @SaschaSchwarze0 @openshift-merge-robot